cansirin commented 1 year ago

Description

discord username: csirin#5041

closes #1115

Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.

Things to check before creating a PR

[ ] PR must be created for an issue with approved tag. Otherwise PR will be rejected.
[ ] Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
[ ] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
[ ] Related file selection: Only relevant files should be touched and no other files should be affected.
[ ] Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
[ ] Clean commit history: The commits where the changes are made should be clear and organized.
[ ] Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

[ ] A new feature (a change that adds a new feature, not a breaking change)
[ ] A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
[ ] A breaking change
[ ] Documentation change

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

Test Configuration:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
deprem-yardim-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 21, 2023 at 1:23AM (UTC)

usirin commented 1 year ago

Correct labels are gonna come in another pr, possibly as part of #1124

MaksuCode commented 1 year ago

This is tested on feature branch, passed.