acikyazilimagi / deprem-yardim-frontend

release canditate: https://rc.afetharita.com/
https://afetharita.com/
Apache License 2.0
896 stars 283 forks source link

fix: reason filter has some duplicate fields #1142 #1145

Closed andyanday33 closed 1 year ago

andyanday33 commented 1 year ago

Description

Reason filter dropdown had some duplicate fields.

discord username: bumshaqalaqa#2973

closes #1142

I have filtered the reasons right after fetching them on the server side.

 Things to check before creating a PR

Creating PR rules

Changes

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
deprem-yardim-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 3:42AM (UTC)
nazdezar commented 1 year ago

It looks like the duplicate entry (Isinma) is now removed in the dev branch. It does not return any data which seems to be expected based on reviewing the RC branch.

usirin commented 1 year ago

TY for the PR, but this is already fixed by #1140 please pull the latest development branch, you'll see we are using a static list now and it doesn't have any duplicates.

The improvements to that is currently being done for #1124 by @mertkaya1033