Closed absolutezero13 closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
deprem-yardim-frontend | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Mar 3, 2023 at 9:05AM (UTC) |
LGTM!
I'm sorry, I was rash. There is a problem. Not every request returns the same response, I mean some of them contain insufficient or irrelevant information. I think we should use "full_text".
For example: id:1614534 Api: https://apigo.afetharita.com/feeds/1614534 Afet harita: https://afetharita.com/en?id=1614534 Screenshot: Rc: https://rc.afetharita.com/en?id=1614534 Screenshot: vercel preview: https://deprem-yardim-frontend-6xmb3tl96-afet.vercel.app/en?id=1614534 Screenshot: Response:
@hackerone-yusuf I've changed it to full_text. Can you check?
Yes, it works as expected now, thanks. But I saw the email info on one of them, I guess this kind of personal information should be filtered again. Should I open a new issue for that?
Yes, it works as expected now, thanks. But I saw the email info on one of them, I guess this kind of personal information should be filtered again. Should I open a new issue for that?
Hm, I am not sure about this to be honest. But I don't think there should be another issue since this is not merged.
@absolutezero13 Alright then, thank you again.
... because node v14 doesn't support replaceAll.
i am confused, why are we making a change for node 14?
@usirin I'm not sure where but while setting up this project there was a spesific node version requirement that is around v14 or something. But if it's node v15 or above in production then it will be fine but even then there is no need to use replaceAll when there is regex.
Description
replaceAll
function toreplace
because node v14 doesn't supportreplaceAll
. Parser was crashing on the server side because of this.fizikiDurum
property for the description as it looks like the most suitable to me. But we can change it, since the bigger problem is solved, that's why I wanted to create this PR.discord username: afetharita#0001
closes #issue #1205 #1210
Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.
Things to check before creating a PR
Creating PR rules
Changes
How were these changes tested?
Please describe the tests you did to test the changes you made. Please also specify your test configuration.
Test Configuration: