search

acil-bwh / SlicerCIP

Slicer extension for the Chest Imaging Platform
BSD 3-Clause "New" or "Revised" License
15 stars 22 forks source link

COMP: Use vtkMRMLLabelMapVolumeNode #1

Closed lassoan closed 8 years ago

lassoan commented 9 years ago

A new class for labelmap nodes (vtkMRMLLabelmapNode) was introduced into the Slicer core that replaces the old method of storing segmentation in a vtkMRMLScalarVolumeNode with a custom “labelmap” attribute set to "1". See details here: http://www.slicer.org/slicerWiki/index.php/Documentation/Labs/Segmentations#vtkMRMLLabelMapVolumeNode_integration

This change in the Slicer core requires modification of your extension. See the suggested change in this commit.

ayarmarkovich commented 9 years ago

Loadable/RegionType module is not used. Loadable/RegionTypeDisplay module needs to be updated.

acil-bwh commented 9 years ago

Alex, Should we go ahead and make the change? Our extension is currently in experimental mode and is moving with the nightly built of Slicer

Raul

ayarmarkovich commented 9 years ago

Raul,

Either Andras or myself need to migrate RegionTypeDisplay module. I can do it once Slicer is updated

Alex

lassoan commented 9 years ago

I'm not sure what Slicer update we need to wait for (the labelmap related changes have been integrated into the core).

ayarmarkovich commented 9 years ago

I just committed the change to RegionTypeDisplay module to use vtkMRMLLabelMapVolumeNode. Nothing else needs to be updated in this extension.

jcfr commented 8 years ago

For future reference, change originally proposed by @lassoan have been integrated by @ayarmarkovich in 6897e4e3b76225

This PR could now be closed.