search

acil-bwh / SlicerCIP

Slicer extension for the Chest Imaging Platform
BSD 3-Clause "New" or "Revised" License
15 stars 23 forks source link

Parenchyma analysis segmentation support #34

Closed lassoan closed 2 years ago

lassoan commented 3 years ago

This pull request includes https://github.com/acil-bwh/SlicerCIP/pull/32 and adds further fixes (such as report generation), design improvements and code refactoring.

@rbumm please test if everything works as expected. I've changed the API of the logic class, so you may need to adjust Lung CT Segmenter module accordingly.

rbumm commented 3 years ago

Very good, all works well. The Lung CT Segmenter has no labelmap output anymore and does not interact with the logic of Parenchyma Analysis.

lassoan commented 3 years ago

Great, thanks @rbumm for testing.

@rjosest it would be great if you could merge this.

lassoan commented 2 years ago

@rjosest it would be great if you could merge this.

lassoan commented 2 years ago

The pull request now includes a fix for a build error that is caused by recent Slicer API updates (removal of an obsolete class).

lassoan commented 2 years ago

@rjosest Please merge. The fix is required for SlicerCIP extension to appear in the extensions manager. To allow keeping SlicerCIP extension functional when Slicer API changes, without the need for you to review and approve each pull request, you may consider granting me write access to this repository.

lassoan commented 2 years ago

@rjosest Please merge. Thank you!

rbumm commented 2 years ago

Yes, would be great if the merge could be done.

rjosest commented 2 years ago

@lassoan @rbumm Thank you for this fix and my apologies for missing the merge. I reviewed the changes and look good from my end.