search

acil-bwh / SlicerCIP

Slicer extension for the Chest Imaging Platform
BSD 3-Clause "New" or "Revised" License
15 stars 22 forks source link

COMP: Fix VTK-9.1 compatibility #37

Closed lassoan closed 2 years ago

lassoan commented 2 years ago

QVTKOpenGLNativeWidget::GetRenderWindow was renamed to QVTKOpenGLNativeWidget::renderWindow() some time ago, but the old method name was still kept, so it was not an issue that SlicerCIP still used the old name.

However, the old method name was removed in VTK-9.1, therefore we need to switch to that in recent VTK versions.

lassoan commented 2 years ago

@rjosest It is a fairly trivial change, please merge it to allow CIP extension to become available again in the latest Slicer Preview Release. If you grant me write access to the repository then I can merge such changes and I don't need to bother you with them.

lassoan commented 2 years ago

@rjosest We plan to release Slicer5 in a couple of days and we want to ensure that all major extensions are available for it. To avoid pressuring you into reviewing and merging changes, we'll fork this repository in the Slicer organization so that we can do this work ourselves. If you can give us write access to this repository or commit to merge essential pull request then we can switch back to using this repository.