search

acil-bwh / SlicerCIP

Slicer extension for the Chest Imaging Platform
BSD 3-Clause "New" or "Revised" License
15 stars 22 forks source link

Chest Imaging Platform fails to build for Slicer Preview 5.1 #39

Open jamesobutler opened 1 year ago

jamesobutler commented 1 year ago

As seen at https://slicer.cdash.org/build/2831700/configure this extension is not building successfully for Slicer 5.1 which will soon become a stable Slicer 5.2 version.

@pieper switched to using this upstream repo in https://github.com/Slicer/ExtensionsIndex/commit/36a92844394cba0e07bae222515f0333d81312c4, but this repo doesn't appear to have the necessary compatibility fixes that were issued at https://github.com/Slicer/SlicerCIP/tree/develop.

lassoan commented 1 year ago

I have not had the time to backport the fixes yet, so updating to use the upstream repository was too early. I'll try to address this today.

jamesobutler commented 1 year ago

@lassoan It is a bit confusing to me why the Windows platform configured successfully (https://slicer.cdash.org/build/2831686/configure) with C++11 while only macOS and Linux builds had the configuration error.

lassoan commented 1 year ago

These will fix the build problems:

jamesobutler commented 1 year ago

@lassoan Is SlicerCIP going to switch to a fork at https://github.com/Slicer/ChestImagingPlatform for the superbuild project in this repo. This being because there hasn't been any new activity at https://github.com/acil-bwh/ChestImagingPlatform since 2016 with a low likely of your PR being integrated?

lassoan commented 1 year ago

CIP follows a very confusing practice of using a the developer branch as main branch and the master branch is just some kind of release branch (although there is a separate release branch, too). So, all the activity is in the https://github.com/acil-bwh/ChestImagingPlatform/tree/develop branch. We are also in regular contact with @rjosest. It should be merged very soon, or else we'll switch back to our fork.