search

acimpoeru / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

VC11 build fix. #119

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Install VC11 Beta
2. Try to build google-glog
3. See strange errors like "missing ; before <"

VC11 contains full STL11 library, so macro
#define hash  hash_compare
in port.h breaks STL internals inside <vector> header.

I added this guard to port.h (at line 99):

/* In windows-land, hash<> is called hash_compare<> (from xhash.h) */
/* VC11 provides std::hash */
#if defined(_MSC_VER) && (_MSC_VER < 1700)
#define hash  hash_compare
#endif

Original issue reported on code.google.com by TheDZ...@gmail.com on 26 Mar 2012 at 8:16

GoogleCodeExporter commented 8 years ago 
Looks reasonable, thanks for the fix.

Could you sign our Individual Contributor License Agreement, please? It
seems that we need to ask you to sign this to avoid any troubles. The
process is just submitting an HTML form, and it shouldn't take your
time so much.

http://code.google.com/legal/individual-cla-v1.0.html

Please note that these forms do not transfer copyright: the
contributor retains her ownership in the work. The CLA just grants
Google a "perpetual, non-exclusive, royalty-free, etc..." right to use
the work, sublicense it, and so on.

Original comment by shinichi...@gmail.com on 9 May 2012 at 8:31

GoogleCodeExporter commented 8 years ago 
Thank you for response! 
CLA accepted by me (according to your link).

Original comment by TheDZ...@gmail.com on 9 May 2012 at 12:00

GoogleCodeExporter commented 8 years ago 
Fixed in http://code.google.com/p/google-glog/source/detail?r=110

Thanks again for your patch!

Original comment by shinichi...@gmail.com on 14 May 2012 at 7:44

GoogleCodeExporter commented 8 years ago

Original comment by shinichi...@gmail.com on 14 May 2012 at 7:44