acimpoeru / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

make install should not depend on unittests building. #177

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.  Put a build bug into a unit test file - like 
https://code.google.com/p/google-glog/issues/detail?id=121
2. Try to make install

What is the expected output? What do you see instead?

I expect to install the program.  Instead I get a compilation error like the 
one described in issue 121.

What version of the product are you using? On what operating system?

glog 0.3.3 
Clang OS/X 10.8 (also fails on 10.7, 10.9)

Please provide any additional information below.

The make install target shouldn't break if the unit test build is broken - 
particularly if small build issues tend to linger for 18 months... 

This behavior isn't providing you any extra safety, particularly since the unit 
tests don't actually _run_ when you make install, and it more or less forces 
you to distribute a patched version of the source if you are using it as part 
of another library.

I keep installing glog on a Mac, getting this error, and then remembering I 
need to patch.

Original issue reported on code.google.com by tom.ritc...@gmail.com on 18 Nov 2013 at 7:48