search

acimpoeru / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

Why extension in the middle of the filename? #89

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Source code:
logging.cc:685 - CreateLogfile()
string string_filename = base_filename_+filename_extension_+
                           time_pid_string;

I think the filename should been composed as:
base_filename_+time_pid_string+filename_extension_

Original issue reported on code.google.com by zhangpei...@gmail.com on 12 Jun 2011 at 1:53

GoogleCodeExporter commented 8 years ago 
Second this

Original comment by kikijiki...@gmail.com on 14 Oct 2012 at 12:51

GoogleCodeExporter commented 8 years ago 
I think log file name pattern can be a flag, such as 
DEFINE_string(log_file_name_pattern, "%n.%h.%u.%p.%s.%t.log",
              "glog log file name pattern, &n means binary name, "
              "%h means hostname, %p means pid, %s means severity,"
              " %t means time");

Original comment by chen3feng on 4 Mar 2013 at 9:11