search

acimpoeru / opencurrent

Automatically exported from code.google.com/p/opencurrent
0 stars 0 forks source link

NSTest broken (silently) #10

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
NSTest is failing (the multigrid solver isn't converging for some reason, 
though it appears to be spurious, as the L2 error is zero!)

Furthermore, due to a missing ASSERT, this failure is going unreported.

Original issue reported on code.google.com by andrewhh...@gmail.com on 13 May 2010 at 10:43

GoogleCodeExporter commented 8 years ago 
This is broken (I think) because NSTest runs a Eqn_IncompressibleNS3D<float> 
with 
max_divergence at its default of 1e-5, which the multigrid solver can't achieve 
in 
single precision.  (L2 error is zero up to rounding error, and the LINF error, 
which 
is what we're testing convergence against, is still 6e-5 or so.)

The easy fix is modifying the test parameters to solve to 1e-4, which I'm doing 
(and 
will commit, unless I hear otherwise.)  The right fix is probably to set the 
default 
for <float> divergence to a more reasonable value.

Original comment by andrewhh...@gmail.com on 13 May 2010 at 11:22