search

acisops / dpa_check

DPA check tool
https://acisops.github.io/dpa_check
1 stars 3 forks source link

update dpa_check for acis_thermal_check 3.0 #21

Closed jzuhone closed 4 years ago

jzuhone commented 4 years ago

Description

This PR implements an update to achieve compatibility with acis_thermal_check version 3.0 (PR https://github.com/acisops/acis_thermal_check/pull/25). In essence, it does the following:

  1. Subclasses ACISThermalCheck to DPACheck and stores all of the information specific to the 1DPAMZT model inside this class, such as validation limits, histogram limits, etc.
  2. calc_model becomes the _calc_model_supp method which overrides a stub in the ACISThermalCheck class. This is designed to put the common model functionality in the super class and allow for model-specific customizations to be carried out in this method.
  3. Command-line arguments are now passed to the run method instead of the class __init__.
  4. Incorporates the new acis_thermal_check testing machinery and stores answers inside the package

Testing

Gregg140 commented 4 years ago

Looks good to me.

jzuhone commented 4 years ago

@taldcroft want to look here too real quick? I’ll have updates for the other models but you probably only also need to look at acisfp_check when I’ve posted that here in a bit.