ackama / lighthouse-matchers

Provides RSpec matchers for executing and evaluating Google Chrome Lighthouse audit scores
MIT License
14 stars 1 forks source link

feat: include measured score in failure message #26

Closed G-Rath closed 10 months ago

G-Rath commented 3 years ago

Fixes #14

G-Rath commented 3 years ago

(it'd be good to have #23 actioned before merging this, just so that releasing it taken care of automatically)

robotdana commented 1 year ago

i think i'll merge #32 in favour of this unless you have a strong attachment to it, it only runs the audit once

G-Rath commented 1 year ago

I'm not super fussed, other than to point out we could have landed this one as-is then tackled the "run audit once" in another PR since that'll require more review and #32 is currently failing CI, but we know we want this change either way (there's no harm in doing multiple releases either)