search

ackama / rails-template

Application template for Rails 7 projects; preloaded with best practices for TDD, security, deployment, and developer productivity.
Other
300 stars 15 forks source link

Consider using `mikepenz/action-junit-report` to annotate results on PRs #397

Open G-Rath opened 1 year ago

G-Rath commented 1 year ago

It's easy enough to have rspec output results in junit format, which we could combine with mikepenz/action-junit-report to annotate failing specs

(we could also use this with rubocop as that supports outputting junit too)

eoinkelly commented 1 year ago

I'm assuming are the same kind annotations that our eslint setup already supports. I must admit that I personally don't find much value from them but that might just be me :shrug: Happy to go with what the consensus wants here.

robotdana commented 1 year ago

i personally find it easier to read the output in the log as it's the same as what i am used to when running tests locally, i don't mind the addition but i'm unlikely to look at them

eoinkelly commented 1 year ago

I'm removing ready for dev label for now. I don't think we have much consensus that this feature would be particularly useful. More discussion needed.

G-Rath commented 1 year ago

@eoinkelly we marked this as ready for dev because we got consensus - I believe overall it was more that there weren't any strong disagreements or downsides not to rather that more than a minority would find it useful, but it was consensus none the less.

Fwiw I feel like this was at a guild meeting while you were on leave, but maybe you were there..?

I'll do a PR this week and we can start using it on a few projects.

G-Rath commented 1 year ago

I've created https://github.com/ackama/aws_ec2_environment/pull/9 to showcase this in action

image