search

ackama / rails-template

Application template for Rails 7 projects; preloaded with best practices for TDD, security, deployment, and developer productivity.
Other
307 stars 18 forks source link

Consider using SVG for default favicon #398

Open mischa-s opened 2 years ago

mischa-s commented 2 years ago

Modern browsers now support using SVGs for favicons - should we have a stock favicon which uses https://www.rubydoc.info/github/rails/webpacker/Webpacker/Helper:favicon_pack_tag in the generated template to encourage projects down this path and make it easy?

robotdana commented 1 year ago

we should choose a random emoji https://twitter.com/LeaVerou/status/1241619866475474946

robotdana commented 1 year ago

maybe our approach for predefining a range of icons in the template needs to be further thought about

should the template be defining icons or icons that 404? should we insist on a favicon.ico at root for various tools? (strava apparently does this)

we should probably not supply default generic icons as the various defaults when things are missing are better than explicitly defining something wrong

robotdana commented 1 year ago

maybe we should have comments with todos for here is where your icon goes

eoinkelly commented 1 year ago

Do browsers still cache old icons for ages? I think our advice should include making sure that your icon has a fingerprint in the filename and not to rely on default /favicon.* naming to avoid these issues.

Overall I am not in favour of us adding a default favicon. I am in favour of us maybe adding a helpful comment near where they would add it.