search

ackama / rails-template

Application template for Rails 7 projects; preloaded with best practices for TDD, security, deployment, and developer productivity.
Other
306 stars 17 forks source link

ci: install specific version of Rails #501

Closed G-Rath closed 11 months ago

G-Rath commented 1 year ago

We lock the version of Rails that can be used for the template but don't ensure that version is installed when running CI.

This seems to work fine in CI but locally even though the correct version of Rails gets reportedly installed by gem it still ends up trying to use a later version of Rails 😕

eoinkelly commented 1 year ago

When users run this template they will almost certainly be using the latest version of Rails so I'm not sure about locking the version in CI. It will make CI more consistent but also hides that the template is broken for how most people will use it.

G-Rath commented 1 year ago

The reason I'm seeing if we can lock it is because we already lock Rails in the template itself so users cannot use the latest version of Rails, and right now our template is actually broken on v7.0 because of a change in shakapacker but we can't deal with that unless we either lock or do the upgrade to Rails 7.1.

I might have already actually fixed all the problems with Rails 7.1 but still wanted to see how hard it might be to lock CI - turns out this is all we need, though it doesn't work locally for some reason...

G-Rath commented 11 months ago

Closing since I couldn't get this to work locally and we're not expecting a new Rails significant version to come out in the near future 🤷