ackama / rails-template

Application template for Rails 7 projects; preloaded with best practices for TDD, security, deployment, and developer productivity.
Other
294 stars 15 forks source link

feat: run `actionlint` for GitHub Actions variant #518

Closed G-Rath closed 7 months ago

G-Rath commented 9 months ago

While rebasing #466 after #516 was landed I learned that I had actually mucked up my erb for the GitHub Actions workflow - this was only picked up because it was invalid YAML so Prettier errored.

To help avoid mistakes in future, this introduces running actionlint as part of our template CI.

Since doing so means that bin/ci-run now includes a tool that isn't in our CI workflow, this PR can also be seen as the initial nudge towards a possible future with a very different approach to bin/ci-run (including not having it at all) that I've been wanting to bring up for discussion for a bit.