ackama / rails-template

Application template for Rails 7 projects; preloaded with best practices for TDD, security, deployment, and developer productivity.
Other
294 stars 15 forks source link

refactor: apply some formatting fixes #526

Closed G-Rath closed 7 months ago

G-Rath commented 7 months ago

These are some changes that are typically autofixed during generation - while there's no major drawback, I think it's nice to aim for our written template code to match our preferred formatting out of the gate.

MVP goes to home_feature_spec.rb whose lack of a newline upset not one but three cops:

spec/system/home_feature_spec.rb:13:1: C: [Correctable] Layout/IndentationConsistency: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
it_behaves_like "an accessible page"end
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/home_feature_spec.rb:13:37: C: [Correctable] Layout/BlockEndNewline: Expression at 13, 37 should be on its own line.
it_behaves_like "an accessible page"end
                                    ^^^
spec/system/home_feature_spec.rb:13:37: C: [Correctable] Layout/SpaceAroundKeyword: Space before keyword end is missing.
it_behaves_like "an accessible page"end
                                    ^^^