search

ackama / rails-template

Application template for Rails 7 projects; preloaded with best practices for TDD, security, deployment, and developer productivity.
Other
294 stars 15 forks source link

fix: support `shakapacker` v8 #546

Closed G-Rath closed 1 month ago

G-Rath commented 3 months ago

The most notable feature change in v8 is that Shakapacker is now JS package manager agnostic by default, using the packageManager property to determine which package manager to use (otherwise defaulting to npm, like Node itself).

A side-effect of this means that shakapacker:install now merges with existing package.jsons rather than always overwriting it (that way you can set packageManager before running the installer); this means we could potentially refactor some of our package.json related code to reduce duplication but it'll still all work as-is so I've left that for a potential follow-up PR.

There are other breaking changes which are detailed in the upgrade guide but they're mainly around fixing existing behaviour and removing deprecated stuff like the webpacker namespace; they will be relevant for our existing applications but don't impact new applications.

G-Rath commented 3 months ago

This is currently based off #545 since otherwise CI would fail anyway