search

ackintosh / discv5-testground

Testground plans for discv5.
7 stars 2 forks source link

`--locked` flag for `cargo install` #33

Closed ackintosh closed 2 years ago

ackintosh commented 2 years ago

cargo install ignores Cargo.lock by default. Now builds on this project are failing due to incompatibility of enr v0.6.1, which is a dependency of discv5. Note: Currently we are using discv5 on master branch, not published on crates.io.

In order to fix the build error, added --locked flag so that cargo install respects Cargo.lock.

mxinden commented 2 years ago

Oh, I wasn't aware of this. Do I understand correctly that we should do this for all our Dockerfiles across the ecosystem?

ackintosh commented 2 years ago

@mxinden Yes, I think so. 💡

ackintosh commented 2 years ago

CI / Run find-node (pull_request) Jul 8 05:36:07.137527 INFO 4.6920s OTHER<< single[007] (bacac7) >> This is a main() function that does nothing, for caching dependencies.

Hmm... the log shows that the dummy main function which is generated by Dockerfile remains in the release binary.

I think main.rss mtime timestamps is not updated, like https://github.com/rust-lang/cargo/issues/9598.