Loosened requirement for psr/http-message - ^1.0|^2.0

ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.

https://ackintosh.github.io/ganesha/

MIT License

585 stars 42 forks source link

Loosened requirement for psr/http-message - ^1.0|^2.0 #107

Closed Rastusik closed 1 year ago

Rastusik commented 1 year ago

This PR was created according to #106

Rastusik commented 1 year ago

@mad-briller not sure what is wrong with the CI but I suppose it is not related to this PR, is it?

coveralls commented 1 year ago

coverage: 93.148% (+1.0%) from 92.12% when pulling a06d4c56ef88fc57780f0cfb2dddc6434856dc8c on Rastusik:psr_http_message_1_or_2 into a4c08dca4a7531585c75554df22b1ac9eeb4527c on ackintosh:master.

ackintosh commented 1 year ago

Yes, that's right. Some tests are flaky so I did rerun the CI and they're passed. 👌

ackintosh commented 1 year ago

I noticed that psr/http-message v2 is not used in the CI, will dig into that later.

https://github.com/ackintosh/ganesha/actions/runs/5901311195/job/16038538654?pr=107#step:5:53

Locking psr/http-message (1.1)

ackintosh commented 1 year ago

I have updated guzzle (in require-dev) and confirmed that:

psr/http-message 2.0 is used in Tests (8.2)
psr/http-message 1.0 is used in Tests (8.2, --prefer-lowest --prefer-stable)
All tests have passed 👍

Rastusik commented 1 year ago

Thanks for the effort :)

ackintosh commented 1 year ago

This PR has been released as v3.1.2. 🎉 https://github.com/ackintosh/ganesha/releases/tag/3.1.2

@Rastusik Thanks for your contribution! @mad-briller Thanks for your review!