Call to undefined function GuzzleHttp\Promise\promise_for() - Githubissues

ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.

https://ackintosh.github.io/ganesha/

MIT License

593 stars 44 forks source link

Call to undefined function GuzzleHttp\Promise\promise_for() #108

Closed jmdelehaye closed 1 year ago

jmdelehaye commented 1 year ago

Version : ackintosh/ganesha 2.0.2 Middleware : Guzzle

After upgrading guzzlehttp/promises from 1.5.3 to 2.0.1 on my project, I get a : Fatal error: Uncaught Error: Call to undefined function GuzzleHttp\Promise\promise_for() in /home/web/sfc/vendor/ackintosh/ganesha/src/Ganesha/GuzzleMiddleware.php:52

And indeed, GuzzleMiddleware needs guzzlehttp/promises functions that were removed in v2.0.

So guzzlehttp/promises dependency could probably be improved:

I think it's not possible to add guzzlehttp/promises in composer.json of ackintosh/ganesha, since it's only a "suggest".
But it could perhaps be handled by creating a ganesha-middleware-guzzle library that would have a dependency on guzzlehttp/promises ?

jmdelehaye commented 1 year ago

Sorry, I just see https://github.com/ackintosh/ganesha/blob/master/src/Ganesha/GuzzleMiddleware.php#L52

So it's fixed in latest versions of ackintosh/ganesha.