search

ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.
https://ackintosh.github.io/ganesha/
MIT License
585 stars 42 forks source link

minor changes #110

Open BFRS02064-vedant opened 7 months ago

BFRS02064-vedant commented 7 months ago

Adding phpredis diver support for redis store

ackintosh commented 7 months ago

@BFRS02064-vedant Thank you for this PR.

Have you tested this with Illuminate\Redis\Connections\PhpRedisConnection? If so, was it successful?

BFRS02064-vedant commented 7 months ago

Yes I have tested with Illuminate\Redis\Connections\PhpRedisConnection

ackintosh commented 7 months ago

Cool. Could you please add a test to verify this change? The following existing tests might be useful as references:

If you need any assistance or have questions, feel free to ask. Thanks for your contribution. 🙂

ackintosh commented 7 months ago

I have made and merged fixes for the CI issue. Could you please merge the latest master branch at your earliest convinience?