Formatting changes - Githubissues

ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.

https://ackintosh.github.io/ganesha/

MIT License

585 stars 42 forks source link

Formatting changes #115

Closed maxbaldanza closed 5 months ago

maxbaldanza commented 5 months ago

Remove docblocks that are no longer needed As we have types already added to the code then the docblocks don't add anything and actually make it harder to maintain
Add CS formatting rules Make sure all classes are consistent by having a new line after the opening tag. At the minute there's a mixture of the two. Removed unused imports
Add phpunit cache to gitignore

maxbaldanza commented 5 months ago

@ackintosh any feedback?

ackintosh commented 5 months ago

Thank you for this PR, and I apologize for the delay! :pray: I will have a look at this by this weekend.

coveralls commented 5 months ago

coverage: 92.647%. remained the same when pulling d3ee82659aea6315b2f5093e8ec45291ee0bd379 on maxbaldanza:formatting into 911e2a8a7e360d44762110995c9f03673a67a18d on ackintosh:master.