Make guzzle optional - Githubissues

ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.

https://ackintosh.github.io/ganesha/

MIT License

585 stars 42 forks source link

Make guzzle optional #45

Closed boekkooi-fresh closed 5 years ago

boekkooi-fresh commented 5 years ago

Since Guzzle is not at the core of this library but a plugin added by the library it should not be required if someone only wants to use the circuit breaker.

coveralls commented 5 years ago

Coverage remained the same at 90.544% when pulling e938141c5c2cb83ec9dbbed1065ef0b2f5b1f8f2 on boekkooi-fresh:patch-2 into 1a4fba802bb3f6545e34f33460561b359f1d7dae on ackintosh:master.

ackintosh commented 5 years ago

Definitely a good improvement! Thank you for this PR. ✨

boekkooi-fresh commented 5 years ago

Thank you :slightly_smiling_face: and thanks for the quick merge :smile: :tada:

ackintosh commented 5 years ago

This PR has been released as v0.4.2. 🎉 https://github.com/ackintosh/ganesha/releases/tag/0.4.2

ackintosh commented 5 years ago

@boekkooi-fresh Btw, if you are using Ganesha, I would appreciate if you could give some consideration to adding the company you belong to the list below: 😃 https://github.com/ackintosh/ganesha#companies-using-ganesha-rocket

boekkooi-fresh commented 5 years ago

Hey @ackintosh, We are currently evaluating it if we start using it in production I will create a PR :smile:

ackintosh commented 5 years ago

I'm looking forward to it! Please let me know If you have any questions. 🐘💨