ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.

https://ackintosh.github.io/ganesha/

MIT License

585 stars 42 forks source link

Improve assertEquals and PHPUnit fixtures #67

Closed peter279k closed 4 years ago

peter279k commented 4 years ago

Changed log

Using the assertSame to replace assertEquals and it can make assert equals strict.
According to the PHPUnit fixtures reference, it should be the protected function setUp() method.
The tests/Ackintosh/Ganesha/Strategy/RateTest.php class namespace should change into Ackintosh\Ganesha\Strategy;.

coveralls commented 4 years ago

Coverage remained the same at 91.852% when pulling d8c578216ae25c4f87cf367776a9806b4c9ab1b6 on open-source-contributions:test_enhancement into 6abb0a9a1ac000c7f573743e185365b982b64bff on ackintosh:master.