feat: Add option to configure HTTP status codes to consider as failure

ackintosh / ganesha

:elephant: A Circuit Breaker pattern implementation for PHP applications.

https://ackintosh.github.io/ganesha/

MIT License

585 stars 42 forks source link

feat: Add option to configure HTTP status codes to consider as failure #82

Closed pvgnd closed 3 years ago

pvgnd commented 3 years ago

closes #73

TODO:

[x] Add HttpClient implementation (+ tests + doc)
[ ] Add Guzzle implementation (+ tests + doc)

coveralls commented 3 years ago

Coverage increased (+0.5%) to 92.197% when pulling 218b8e8a96c70d2ff5987e8b8c350238ae82c9eb on pvgnd:failure-conf into aa4fa2bbc7b8ac0100760382ea3162aeffdfa3f4 on ackintosh:master.

coveralls commented 3 years ago

Coverage increased (+0.3%) to 92.033% when pulling 627e516b939335f3f0e57b9c1023b43867edbe43 on pvgnd:failure-conf into aa4fa2bbc7b8ac0100760382ea3162aeffdfa3f4 on ackintosh:master.

pvgnd commented 3 years ago

@ackintosh could you have a look on the HttpClient implementation before I start to work on the Guzzle implementation?

ackintosh commented 3 years ago

@pvgnd Thank you! I will have a look this weekend or next weekend. I'm sorry to have kept you waiting. 🙇

ackintosh commented 3 years ago

@pvgnd Thank you for the fix! Looks good to me. ✨

pvgnd commented 3 years ago

@pvgnd Thank you for the fix! Looks good to me. ✨

Thanks for the review. I suggest to add same option to Guzzle Middleware but in another PR. What do you think?

ackintosh commented 3 years ago

I agree with you, will merge this PR.

ackintosh commented 3 years ago

@pvgnd The feature has been released as v1.3.0. 🎉 Thank you for your contribution! :octocat:

https://github.com/ackintosh/ganesha/releases/tag/1.3.0