Project Feedback

[ackleyd1]

@chrisvfritz Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Place a nav element at the top of the page that includes (fake) links to other pages
• [x] Use the main element appropriately
• [x] Include three products your store sells, all listed on the same Products page
• [x] For each product, correctly use an article, header, and footer element and one or more section elements
• [x] Use figure and figcaption to show what each product looks like
• [x] Each product includes a nav element with one or more links to related products (the links don't have to go anywhere)
• [x] Use an aside in one or more products to advertise a promotion or discount for that product

I liked the recipe project idea so i tried that

[chrisvfritz]

Well, now I'm hungry. 😛

• Easy-to-read recipe layout 🎉
• Delicious-looking food 🍝
• Probably a Dark Souls reference? ⚔️
• Calvin & Hobbes reference 🐅
• I'm lost on the "chimpanzee taxi drivers" 😄

I only see one area for improvement:

Element attributes with empty values

The values of HTML attributes should never actually be empty. There are some attributes like disabled that don't have values at all, but for empty quotes like this:

<img src="cheesypotatoes.jpg" alt="">
<aside class="">

The attributes should either be removed completely or a value should be provided. For example, the alt attribute is actually required on img elements, so would fill this one in with something like Cheesy potatoes. For the aside above, I'd just remove the class attribute altogether.

[ackleyd1]

Haha i was trying to think of random rating scales, the calvin and hobbes was intentional but the others were just me trying to think of random combinations of words. I also thought itd be pretty cool if a chimpanzee could be your taxi driver hahhah :)

Should be fixed 👍

[chrisvfritz]

Looks great! :shipit: