search

ackwell / BrowserHost

Dalamud plugin for in-game browser rendering. Think OverlayPlugin, but it's in the game itself.
GNU Lesser General Public License v3.0
9 stars 12 forks source link

Inlays discolour UI windows behind them when using GShade #15

Open Kanarisky opened 3 years ago

Kanarisky commented 3 years ago

Describe the bug here: Browser Host inlays seem to be doubly affected by GShade. This primarily affects game UI windows. However it's also visible on the Duty list UI and is plainly visible on the character selection screen.

Steps to reproduce the bug:

  1. Install GShade and use a preset that noticeably impacts graphics
  2. Install XIVLauncher + Browser Host.
  3. Setup a Browser Host inlay that should be transparent (such as a Cactbot Raidboss Timeline/Alerts URL)
  4. Drag a game UI window (such as duty finder or inventory) underneath where you've placed your inlay.
  5. Visit character selection screen.

Expected behavior Nothing out of the ordinary. Inlay is transparent. No discolouration or graphical oddities on UI elements or the character selection screen.

Actual behavior The area of the UI covered by the transparent inlay has been affected by GShade a 2nd time. Because of this, it is darker (most GShade presets darken/increase contrast/saturation) and looks very strange. Areas of character selection screen have dark rectangles.

Screenshots Example 1 (Cactbot timeline-only inlay, hidden) Example 1 (inlay hidden)

Example 1 (Cactbot timeline-only inlay, transparent but not hidden) Example 1 (inlay transparent but not hidden)

Example 2 (Cactbot alerts-only inlay, hidden) Example 2 (inlay hidden)

Example 2 (Cactbot alerts-only inlay, transparent but not hidden) Example 2 (inlay transparent but not hidden)

Example 3 (Char select, GShade OFF, both Cactbot inlays transparent but not hidden) Example 3 (Char select, GShade off)

Example 3 (Char select, GShade ON, both Cactbot inlays transparent but not hidden) Example 3 (Char select, GShade on - see where the Browser Host inlays are)

Other information: Operating System: Windows 10 XIVLauncher version: 6.0.4 Launching as admin?: Nope Using Steam?: Yep Addons/Plugins enabled: These

Additional information GShade preset: SerenayaRealismGameplay

If I toggle GShade off, the problem does not occur. It seems to be an interaction between GShade and Browser Host.

Setting Browser Host to the experimental render mode (BitmapBuffer) under advanced settings does nothing to alleviate the issue.

Additionally, this problem does not occur with transparent RemindMe windows, so there must be a difference between how RemindMe and Browser Host render their stuff.

DAOWAce commented 3 years ago

Can confirm here.

Have to use this plugin to workaround ACT disabling NVIDIA's Gsync when any overlay is drawn.. so now all the overlays get affected by GShade, and subsequently affect the game UI even through KeepFX which shouldn't be possible.

The problems with compatibility between software just keep adding up over the years..

willho01 commented 2 years ago

Did you ever find a workaround for this? Having the same issue.

Kanarisky commented 2 years ago

Nope! I think(?) Attick said that because it's to do with GShade, they won't be investing time into trying to fix it. Seems like it's out of their control.

I ended up uninstalling GShade, sorry.

willho01 commented 2 years ago

Fair enough. Well for now I guess I'll just use ACT to display the overlays rather than browser host. Shame.