search

ackwell / ninjabot

Ninjabot is not 'Just Another Bot'
10 stars 8 forks source link

Common test #74

Closed Mause closed 10 years ago

Mause commented 10 years ago

And of course, I managed to include the IRCConnection tests in here -.- Basically contains some stuff common between tests, some fixes for some tests, and some misc. fixes.

Some important stuff from one of the commits;

Corrected quit function
See http://www.irchelp.org/irchelp/rfc/chapter4.html#c4_1_6 for reasoning.
In short, if no message is provided for quit, the default should be the
nickname.
cyphar commented 10 years ago

what is branching?

But seriously, if you wanna merge two different sets of patches, do them in different branches.

ackwell commented 10 years ago

Indeed, though it isn't of a particularly high issue currently. I can't really complain, considering I'm the one working straight on master >.>

Mause commented 10 years ago

@cyphar; I did try, but forgot to branch off master instead of one my other feature branches :P

cyphar commented 10 years ago

@Mause, nice one.

Mause commented 10 years ago

Oh you