ackwell / ninjabot

Ninjabot is not 'Just Another Bot'
10 stars 8 forks source link

core: implement SSL connections to IRC #76

Closed auscompgeek closed 9 years ago

auscompgeek commented 10 years ago

The bot currently does not connect to IRC over SSL.

We don't want certain three-letter government organisations spying on us, do we? :wink:

cyphar commented 10 years ago

Which three-letter government are you speaking of? We are Australian. The NSA need not spy on us (yet), I'd be more worried about the AFP.

auscompgeek commented 10 years ago

Both work, I suppose.

cyphar commented 10 years ago

By SSL, do you include the whole fiasco that is certificate verification, expiration, revocation, etc? Also, does IRC over SSL support client-side certificates (and should we?)?

auscompgeek commented 10 years ago

I believe Python's SSL/TLS stack verifies certs by default. Yes, many (Atheme, OFTC) IRC services packages allow for using CertFP to authenticate. It'd be interesting to see a bot that supports client-side certs; not many do AFAIK.

auscompgeek commented 9 years ago

What? You mean I can't reopen this issue myself? Goddammit GitHub.

I guess I'll file a new issue.

ackwell commented 9 years ago

Why the fuck did github close this? Ergh.

Ah well, move conversation to #103 from now.

auscompgeek commented 9 years ago

Why the fuck did github close this? Ergh.

I think it was a magic keyword in the PR message. Funny how it didn't close the other two issues I mentioned though.

ackwell commented 9 years ago

You'd think they'd at least make it bring up a box like 'We saw a magic keyword, do you want to close this' instead of just shitting all over it...

On 21 September 2015 at 16:11, David notifications@github.com wrote:

Why the fuck did github close this? Ergh.

I think it was a magic keyword in the PR message. Funny how it didn't close the other two issues I mentioned though.

— Reply to this email directly or view it on GitHub https://github.com/ackwell/ninjabot/issues/76#issuecomment-141884613.