Join/part plugin and sanitisation improvements

ackwell / ninjabot

Ninjabot is not 'Just Another Bot'

10 stars 8 forks source link

Join/part plugin and sanitisation improvements #89

Closed gnustomp closed 10 years ago

gnustomp commented 10 years ago

Plugin for interactive joining and parting of channels.
Sanitise outbound messages without destroying content.

auscompgeek commented 10 years ago

I wonder what would happen if I s/$/\x00PRIVMSG .../ with this...

ackwell commented 10 years ago

Do it and report back. That's been a recurring security flaw with it. On 28/05/2014 11:16 pm, "David" notifications@github.com wrote:

I wonder what would happen if I s/$/\0PRIVMSG .../ with this...

— Reply to this email directly or view it on GitHubhttps://github.com/ackwell/ninjabot/pull/89#issuecomment-44404593 .

gnustomp commented 10 years ago

I wonder if just replacing backslashes with literal ones would work better. Then one line of code will work for all escape sequences. If there aren't any objections and unintended behavior, I'll submit a pull request.