search

acl-org / acl-anthology

Data and software for building the ACL Anthology.
https://aclanthology.org
Apache License 2.0
432 stars 292 forks source link

Fix first name in Shears paper #3716

Closed jpablomch closed 2 months ago

jpablomch commented 3 months ago

This PR fixes an error in the author's name for the paper "Shears: Unstructured Sparsity with Neural Low-rank Adapter Search" at NAACL-24.

Juan Munoz -> Juan Pablo Munoz

nschneid commented 3 months ago

Thanks for raising this. The PDF at https://aclanthology.org/2024.naacl-industry.34/ actually says "J. Pablo Muñoz". Anthology policy is that the metadata should reflect the PDF.

jpablomch commented 3 months ago

Thanks for raising this. The PDF at https://aclanthology.org/2024.naacl-industry.34/ actually says "J. Pablo Muñoz". Anthology policy is that the metadata should reflect the PDF.

Hi @nschneid , thanks for your prompt response. Yes, the J. stands for Juan -> Juan Pablo Muñoz. The current record is missing "Pablo," as included in the PDF. Please refer to the other papers by the same author, which follow this same pattern: https://aclanthology.org/people/j/juan-pablo-munoz/

Thank you in advance for your help.

nschneid commented 3 months ago

I have edited the paper metadata to match the PDF. Please add an entry to name_variants.yaml so it will be listed on the same page as https://aclanthology.org/people/j/juan-pablo-munoz/

jpablomch commented 2 months ago

I have edited the paper metadata to match the PDF. Please add an entry to name_variants.yaml so it will be listed on the same page as https://aclanthology.org/people/j/juan-pablo-munoz/

Thanks, @nschneid. I have added the name variants.

jpablomch commented 2 months ago

Hi @nschneid and @mjpost , is there anything else needed to merge this PR? Thanks in advance for your help.

mjpost commented 2 months ago

I hadn't noticed the followups. This looks good. Thank you!