search

acl-org / acl-anthology

Data and software for building the ACL Anthology.
https://aclanthology.org
Apache License 2.0
406 stars 280 forks source link

Author order incorrect just on paper list page (D17 specifically) #47

Closed knmnyn closed 6 years ago

knmnyn commented 6 years ago

via email.

The author order seems likely to be a UI issue in the new anthology. When I click on each of the papers, I see a different (correct) order of authors on the paper details page. I also compared this to the old anthology. The old anthology appears to have the authors in the correct order too.

My guess is that the metadata has the correct order, but the web rendering is somehow reordering the authors on the page (only in paper list in the new anthology).

See screenshots:

knmnyn commented 6 years ago

The same code from the helper views/papers/_paper.html.erb seems to generate different orderings in the output when run by views/volume/show (incorrect) and views/people/show (correct).

@villalbamartin Was this a rails or ruby library update that changed any guarantees about how .each retrieves information?

villalbamartin commented 6 years ago

We didn't make any change to the ruby library. I can take a look to see why the order is not being respected.

knmnyn commented 6 years ago

Another report:

Hi Min,

The authors show in a strange order:

https://aclanthology.coli.uni-saarland.de/events/naacl-2018

For example:

Pdf Export Search Attentive Interaction Model: Modeling Changes in View in Argumentation [N18-1010]: Graham Neubig | Qinlan Shen | Carolyn Rose | Yohan Jo | Shivani Poddar | Byungsoo Jeon

If you click on a paper, the summary is correct:

Authors: Yohan Jo | Shivani Poddar | Byungsoo Jeon | Qinlan Shen | Carolyn Rose | Graham Neubig

https://aclanthology.coli.uni-saarland.de/papers/N18-1010/n18-1010

This author reordering seems to be happening for all papers. Is this on purpose?

knmnyn commented 6 years ago

This seems to be due to problems with the event view using the embedded papers view. When using it embedded, the each operator appears to use person_id as a sort, instead of using the default collection enum. Any ideas how to fix? @villalbamartin @CTNLP ?

knmnyn commented 6 years ago

Ok, fixed. I took out the includes clause that was eager loading the people connected join table, which had the side effect of reordering the authors on the volume page. Seems to work now.