search

acl-org / acl-style-files

Official style files for papers submitted to venues of the Association for Computational Linguistics
633 stars 168 forks source link

Enable pdflatex+hyperref to generate ToC-metadata #16

Closed hbuschme closed 9 months ago

hbuschme commented 1 year ago

The style file was configured so that LaTeX would not to generate a table of contents. It was stated that this is “never going to [be] need[ed].” This configuration has been part of the ACL style files since, at least, ACL 2000.

I do not agree that the table of contents is not needed. While it may be true that a table of contents will never be printed on the first page of an ACL-paper, these lines also prevent hyperref from generating the toc-metadata that PDF-viewers use to show an electronic table of content for navigating the PDF, a feature that I find immensely useful.

This pull request deletes these three lines from the style file and re-enables the generation of ToC metadata

danielgildea commented 1 year ago

I'm not able to replicate the problem - I do get a sidebar with section headings in my pdf viewer when I compile the instructions document with the current style file using pdflatex. Can you provide details about what is not working for you?

hbuschme commented 1 year ago

Thanks for the quick reply! You are right and I am sorry, it turns out that it is really not a problem with the acl.sty file provided in this repository.

I encountered the problem with acl2023.sty, as distributed on the ACL 2023 website, and was able to fix it with the change I suggested in this pull request. I simply and wrongly assumed that the file in this repository was basically the same, maybe slightly less recent.

A diff now shows me that there are indeed differences to acl2023.sty: here hyperref is loaded after natbib (there is even a comment noting that this is important). As I now see, this was introduced in commit bace58f. acl2023.sty was apparently forked from an earlier version (which indicates that there seems to be a lack of authoritative development of the style files).

Applying this change to acl2023.sty now also gives the ToC.

Sorry for the confusion!