Updating LaTeX style files based on ACL 2023

acl-org / acl-style-files

Official style files for papers submitted to venues of the Association for Computational Linguistics

633 stars 168 forks source link

Updating LaTeX style files based on ACL 2023 #18

Closed jkkummerfeld closed 10 months ago

jkkummerfeld commented 11 months ago

This PR incorporates changes from the ACL 2023 LaTeX style files into this repository.

danielgildea commented 11 months ago

This PR would undo the recent fixes/improvements in the github repository. In particular,

hyperref should be loaded later (Issue #16)
\flushbottom causes uneven columns (Issue #11)
moving \bibliographystyle to the .sty file

There is also a bunch of stuff that seems to be specific to ACL 2023.

The only other changes I see in here are adding \citeposs and including inconsolata.

jkkummerfeld commented 11 months ago

Thanks for the feedback! I implemented this after discussion in issue #6 and didn't look closely at the history of the file (sorry!).

I've made a modification to the PR so it only adds new content, which is quite minimal. Happy for this PR to be closed without merging if that's best.

The more critical thing is to get the Overleaf template in line with the contents of this repository.

danielgildea commented 10 months ago

Thanks for updating the pull request.

I could go either way on these changes - there's something to be said for keeping the files simple. What do you think, @mjpost and @davidweichiang ?

davidweichiang commented 10 months ago

I'm fine with including \citeposs and \usepackage{inconsolata}. I am uncertain about the Limitations and Ethics sections for modularity reasons -- style guidelines should go here, content guidelines should go somewhere else. Especially if there are venues using these style files that don't require Limitations and Ethics sections.

jkkummerfeld commented 10 months ago

I've amended it to remove those sections. The content vs. style distinction is a good point.