search

acl-org / aclpubcheck

Tools for checking ACL paper submissions
MIT License
598 stars 47 forks source link

Parsing error when top margin is too small #21

Closed casey-meehan closed 2 years ago

casey-meehan commented 2 years ago

Our paper caused a parsing error with top margins that were too small (on pages 2 and 7). As such, we could not see what the actual formatting problem was (no errors were reported for the paper, only parsing errors were reported).

I've attached the original problematic paper (which has been fixed and uploaded) as well as the stack trace of the parser. meehan_bad_margin.pdf meehan_colab_error

crux82 commented 2 years ago

Thank you.

I see that such a problem arises only on colab. It is quite difficult to replicate on my laptop (where this error does not occur)

crux82 commented 2 years ago

The last commit https://github.com/acl-org/aclpubcheck/commit/fef5a4635a9a277c80b7eff2f3cff42c417e1347 should correct your issue.

Can you please confirm it and close this issue?

Thank you for your support!

crux82 commented 2 years ago

Can you share with me your PDF in a private message?

PradeepNalluri commented 2 years ago

Hi, sure

PradeepNalluri commented 2 years ago

Shared the page. To confirm the following is the stack trace image

crux82 commented 2 years ago

I should have fixed the issue. It was a similar bug fixed in commit https://github.com/acl-org/aclpubcheck/commit/fef5a4635a9a277c80b7eff2f3cff42c417e1347

Can I ask you to check the ill-formatted version of your paper to check it if works now?

Thanks!

PradeepNalluri commented 2 years ago

It's working now

image

thanks for all your work and fix!