Closed tristanjasper closed 2 years ago
Latest commit: 379e18c7df1147b4fcd9b80c84b4367cb033d0ee
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Purpose 🚀
Refactor Popover to only render content (& Tip subcomponent) when popover is open and visible. This is to improve overall rendering performance on a page when
Reducing dom nodes that are not visible to the user will improve overall performance for the browser. This change also makes testing easier as previously multiple nodes in popover content elements would be found.
Changes include
Content
component withTransition
component to detect opacity changesisAlwaysOnDom
prop toContent
component so that it can still be rendered the current way for backwards compatibilityAdditional changes
Updates all RTL/Cypress tests for new approach Fixes some other minor bugs
Notes ✏️
details of code change / secondary purposes of this PR
Updates 📦
If you have changed a component's source code (not stories, specs, or docs), before merging your branch run
yarn changeset
. This will prompt you to:Storybook 📕
http://storybooks.highbond-s3.com/paprika/your-branch-name
Screenshots 📸
optional but highly recommended
References 🔗
relevant Jira ticket / GitHub issues