acl-services / paprika

🌶 A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

fix(DataTable): UXD-2004 fix horizontal toolbar calculation #1240

Closed tristanjasper closed 2 years ago

tristanjasper commented 2 years ago

Purpose 🚀

https://aclgrc.atlassian.net/browse/UXD-2004

Fix table width calculation when vertical scrollbar showing

Notes ✏️

details of code change / secondary purposes of this PR

Updates 📦

If you have changed a component's source code (not stories, specs, or docs), before merging your branch run yarn changeset. This will prompt you to:

Storybook 📕

http://storybooks.highbond-s3.com/paprika/your-branch-name

Screenshots 📸

optional but highly recommended

References 🔗

relevant Jira ticket / GitHub issues

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 7cbf2ecc5e7c33c0066a571bde87c4ca8dc09494

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | @paprika/data-table | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tristanjasper commented 2 years ago

This is WIP. Still seeing an issue where the width is not calculated correctly when the data changes or rows are added. image

Tried a few approaches to fix this, calculating width after height calculation has been rendered, but didn't find an easy fix