acl-services / paprika

🌶 A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

fix(TimePicker): ASM-2106 period selection doesn't work when hour is 12 #1244

Closed michellehuang7 closed 2 years ago

michellehuang7 commented 2 years ago

Purpose 🚀

When HH === 12, the AM/PM period selector isn't working properly

Notes ✏️

details of code change / secondary purposes of this PR

Updates 📦

If you have changed a component's source code (not stories, specs, or docs), before merging your branch run yarn changeset. This will prompt you to:

Storybook 📕

http://storybooks.highbond-s3.com/paprika/ASM-2106--fix-timepicker

Screenshots 📸

Before:

https://user-images.githubusercontent.com/92059030/159816858-5c877b6f-4ae9-4bf3-b632-4ab2267b98d0.mov

After:

https://user-images.githubusercontent.com/92059030/159817011-b00c37d3-15c9-4ab9-9c5a-ece04f3f051e.mov

References 🔗

relevant Jira ticket / GitHub issues

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 0b09234fd78097489729f0380d98694ac718ee66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @paprika/time-picker | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR