search

acl-services / paprika

🌶 A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

TW-2941 Make `internalHandleOnClick` and `id` props optional #1252

Closed AndreyChernykh closed 2 years ago

AndreyChernykh commented 2 years ago

Purpose 🚀

Make internalHandleOnClick and id props optional.

These props get added with a React.cloneElement() call and provide the necessary functionality to the items. Even though they're required for the component to work, the consumer doesn't provide them manually. So, they don't need to be flagged as required in the propTypes / type definitions.

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 6433795235769a2daf76f34d0ac99e796b7c5ed1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ----------------------- | ----- | | @paprika/list-box | Patch | | @paprika/inline-editors | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR