search

acl-services / paprika

🌶 A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

fix(Filter): UXD-2067 Filter panel miss padding #1254

Closed ShanAtDiligent closed 2 years ago

ShanAtDiligent commented 2 years ago

Purpose 🚀

Add missing padding back to filter panel to match the panel style ticket: https://aclgrc.atlassian.net/browse/UXD-2066

Storybook 📕

http://storybooks.highbond-s3.com/paprika/UXD-2066-missing-padding-on-filter-panel

Screenshots 📸

Screen Shot 2022-04-07 at 1 09 18 PM

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 9f10d8c2ce17585604ceae9b6a9f2c3116fad744

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | -------------------- | ----- | | @paprika/filter | Patch | | @paprika/stylers | Patch | | @paprika/data-header | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mikrotron commented 2 years ago

Why not just use <Panel.Content>? https://github.com/acl-services/paprika/tree/master/packages/Panel/src/components/Content

Here: https://github.com/acl-services/paprika/blob/master/packages/Filter/src/Filter.js#L85

The styling looks the same, and the ref is being forwarded, so I think it should work all the same?