acl-services / paprika

🌶 A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

fix(ListBox): VRMRG-1553 Display divider when there are results #1263

Closed michellehuang7 closed 2 years ago

michellehuang7 commented 2 years ago

Purpose 🚀

Display divider when there are results below. (Also prevent filter from matching with divider)

Notes ✏️

Add another filter to filter out the dividers that do not have any options folowing

Updates 📦

If you have changed a component's source code (not stories, specs, or docs), before merging your branch run yarn changeset. This will prompt you to:

Storybook 📕

http://storybooks.highbond-s3.com/paprika/VRMRG-1553--display-list-box-divider

Screenshots 📸

Before:

Screen Shot 2022-04-21 at 7 35 34 PM Screen Shot 2022-04-21 at 7 35 39 PM

After:

Screen Shot 2022-04-21 at 7 26 04 PM Screen Shot 2022-04-21 at 7 26 09 PM

References 🔗

https://aclgrc.atlassian.net/browse/VRMRG-1553

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: ee3d1656e747514b4e05cd1a0e8c941155e77aea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | --------------------------- | ----- | | @paprika/list-box | Patch | | @paprika/filter | Patch | | @paprika/inline-editors | Patch | | @paprika/list-box-browser | Patch | | @paprika/list-box-with-tags | Patch | | @paprika/search | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR