acl-services / paprika

๐ŸŒถ A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

fix(CollapsibleCard): TW-3405 Fix collapsible header bug causing unreโ€ฆ #1286

Closed tristanjasper closed 1 year ago

tristanjasper commented 1 year ago

โ€ฆquired re-render leading to cypress test errors

Collapsible Card Header component re-renders unnecessarily when mounting due to an unnecessary state change. More detail here

Ticket: https://diligentbrands.atlassian.net/browse/TW-3405

Purpose ๐Ÿš€

clear, one sentence description of primary purpose of this PR

Notes โœ๏ธ

details of code change / secondary purposes of this PR

Updates ๐Ÿ“ฆ

If you have changed a component's source code (not stories, specs, or docs), before merging your branch run yarn changeset. This will prompt you to:

Storybook ๐Ÿ“•

http://storybooks.highbond-s3.com/paprika/your-branch-name

Screenshots ๐Ÿ“ธ

optional but highly recommended

References ๐Ÿ”—

relevant Jira ticket / GitHub issues

changeset-bot[bot] commented 1 year ago

๐Ÿฆ‹ Changeset detected

Latest commit: c2b06fdb24b793b515698f9a750c7ab3c3be526d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------- | ----- | | @paprika/collapsible-card | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR