Closed Nandez89 closed 6 months ago
Latest commit: 9a163f14827fe2b986ba113c4d0d10d5e9126298
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Purpose 🚀
Previously the forEach on
paprikaLocales
acted as a hidden filter on the merge of locales. Resulting in missingcustomLocales
unless they are also part ofpaprikaLocales
. This was noticed when trying to use the newnl
locale in a package that had not published thenl
assets.Notes ✏️
To avoid this hidden filter. This change makes the merge work on the unique set of languages keys from both params (
paprikaLocales
,customLocales
) resulting in a full merge. Also adds unit tests.Updates 📦
If you have changed a component's source code (not stories, specs, or docs), before merging your branch run
yarn changeset
. This will prompt you to:Storybook 📕
http://storybooks.highbond-s3.com/paprika/your-branch-name
Screenshots 📸
optional but highly recommended
References 🔗
relevant Jira ticket / GitHub issues