acl-services / paprika

🌶 A robust + accessible UI component library for React applications by Galvanize.
MIT License
54 stars 9 forks source link

fix(l10n): Improve locale merging technique #1319

Closed Nandez89 closed 6 months ago

Nandez89 commented 6 months ago

Purpose 🚀

Previously the forEach on paprikaLocales acted as a hidden filter on the merge of locales. Resulting in missing customLocales unless they are also part of paprikaLocales. This was noticed when trying to use the new nl locale in a package that had not published the nl assets.

Notes ✏️

To avoid this hidden filter. This change makes the merge work on the unique set of languages keys from both params (paprikaLocales, customLocales) resulting in a full merge. Also adds unit tests.

Updates 📦

If you have changed a component's source code (not stories, specs, or docs), before merging your branch run yarn changeset. This will prompt you to:

Storybook 📕

http://storybooks.highbond-s3.com/paprika/your-branch-name

Screenshots 📸

optional but highly recommended

References 🔗

relevant Jira ticket / GitHub issues

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 9a163f14827fe2b986ba113c4d0d10d5e9126298

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages | Name | Type | | -------------------------------------- | ----- | | @paprika/l10n | Patch | | @paprika/action-bar | Patch | | @paprika/breadcrumbs | Patch | | @paprika/calendar | Patch | | @paprika/collapsible | Patch | | @paprika/collapsible-card | Patch | | @paprika/collapsible-text | Patch | | @paprika/confirmation | Patch | | @paprika/copy-input | Patch | | @paprika/data-field | Patch | | @paprika/data-grid | Patch | | @paprika/data-header | Patch | | @paprika/date-input | Patch | | @paprika/date-picker | Patch | | @paprika/date-range-picker | Patch | | @paprika/dialog-actions | Patch | | @paprika/dynamic-hyperlink-transformer | Patch | | @paprika/filter | Patch | | @paprika/form-element | Patch | | @paprika/input | Patch | | @paprika/list-box | Patch | | @paprika/list-box-browser | Patch | | @paprika/list-box-with-tags | Patch | | @paprika/overflow-menu | Patch | | @paprika/pagination | Patch | | @paprika/panel | Patch | | @paprika/progress-accordion | Patch | | @paprika/search | Patch | | @paprika/side-navigation | Patch | | @paprika/sortable | Patch | | @paprika/status-tracker | Patch | | @paprika/tag | Patch | | @paprika/takeover | Patch | | @paprika/time-picker | Patch | | @paprika/toast | Patch | | @paprika/uploader | Patch | | @paprika/collapsible-checklists | Patch | | @paprika/inline-editors | Patch | | @paprika/table | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR