Leychess Variants - Githubissues

leytilera commented 7 years ago

another try ( i dont know how to PR the variants separately)

mi-g commented 7 years ago

Thanks for the PR. I have a few concerns with it though (nothing too bad):

some image files have an upper case extension, like cavalierchess-600x600-3d.JPG or leychessalpha-thumb.PNG. There is a risk it breaks some scripts. Can you rename those files to cavalierchess-600x600-3d.jpg, leychessalpha-thumb.png, ... ?
you name your PR "Leychess Variant" but commit 6 new variants. I wouldn't do that myself and really would like we introduce new games one by one. Just refork the jocly project and push the changes for leychessalpha only, then submit the PR

leytilera commented 7 years ago

how i should refork it? when i press on fork , i can do nothing there, because i already forked it

mi-g commented 7 years ago

There are probably other ways, but at least you can clone or zip-save your project so that you keep a record of your work, then delete the existing fork and create a new one.

aclap-dev / jocly

Leychess Variants #14