search

aclap-dev / jocly

Javascript library and tools to provide user interface (2D, 3D, VR) and engine for playing board games
https://jocly.com/
Other
71 stars 28 forks source link

Pawn promotion missing #5

Closed cssjunkie closed 6 years ago

cssjunkie commented 7 years ago

In Brusky and De Vasa Chess, the pawns do nothing when reaching the last rank. This ruins these games. I researched them and there's no mention online about those games not having pawn promotion. I can't think of any good reason that it should be omitted, so it has to be an oversight.

Please enable pawn promotion so these games can be enjoyed properly. :-)

ecobabush commented 7 years ago

Today I have played McCooey Chess. I played with white vs computer. A white pawn did nothing when reached the last rank. So it is possible that an implementation of this chess variant have not pawn promotion too.

ecobabush commented 7 years ago

Tonight I have played Glinsky Chess with white vs computer. And Black have made pawn promotion and checkmated. I took a look on the glinsky chess code and code of the others above mentioned variants and think that pawn promotion exists, but something goes wrong with it.

mi-g commented 7 years ago

It can either be a bug or it's just the rules. The best online source for chess variant rules is chessvariants.com but i think i used the Encyclopedia of Chess Variants by David Pritchard as a reference. Fixing promotion issues shouldn't be too hard, even if the geometry being hexagon-based makes things a bit more tricky than with the classical grid geometry. When seeing that kind of issue, it is a good idea to save the game to a file, so the problem can be reproduced very quickly.

ecobabush commented 7 years ago

De Vasa's Chess http://zoldsakk.hu/en/rules.php?v=6devasa Pawns promote on the opposite edge of the board.

Brusky's Chess http://zoldsakk.hu/en/rules.php?v=6brusky Pawns promote on the opposite edge of the board.

McCooey's Chess http://zoldsakk.hu/en/rules.php?v=6mccooey Pawns promote on the opposite two edges of the board.

ecobabush commented 7 years ago

I was wrong with pawn promotion in McCooey's Chess. It exists there. Only 2 bugs are at d9 and g8-g10. The same situation is within Glinski chess. I have made pull request with bugfixes of those.

ecobabush commented 6 years ago

Today I have made a bugfix of De Vasa chess pawn promotion. A pull request have been made too.

mi-g commented 6 years ago

The PR has been merged. Many thanks !

ecobabush commented 6 years ago

Thank you too for allowing me to contribute here. Today I have made a bugfix of pawn promotion in Brusky chess. PR was made too. Therefore this issue may be closed.

mi-g commented 6 years ago

Your PR has been merged. Many thanks.

raman22feb1988 commented 6 years ago

Sorry to open this closed issue, but I have a question to ask. I should have asked this question quite a little bit earlier, but I was quite busy for the past few days.

Now the pull request has been approved. So, will the pawn promotion changes take effect in the www.jocly.com website immediately or will you have to do a manual update to the website sometime later? If you have to do a manual update to the website sometime later, when you will do it and what is the procedure to do it?

I can start trying, learning, playing and enjoying games of Brusky chess, De Vasa chess and even McCooey Chess and Glinski chess (for the latter two chess variants, pawn promotion was missing only at two points?) only after the bug fixes have been reflected in the www.jocly.com website. Please feel free to close this issue after you have answered my question. :smile:

mi-g commented 6 years ago

The jocly.com website won't be updated before it is entirely replaced with a new version based on Jocly Core (the project in which the promotion issue has been fixed). This will take months.

raman22feb1988 commented 6 years ago

Thank you for answering my question.

So, putting it this way: After all, if I start a game of Brusky chess or De Vasa Chess or even McCooey Chess or Glinski Chess (for the latter two chess variants, pawn promotion was missing only at two points?) on the www.jocly.com website today, then will the pawn promotion still be absent, as of yet?

But not on the Github interface at all?

I mean these following website pages and directing links at least: https://mi-g.github.io/jocly/examples/browser/control.html?game=brusky-chess https://mi-g.github.io/jocly/examples/browser/control.html?game=devasa-chess https://mi-g.github.io/jocly/examples/browser/control.html?game=mccooey-chess https://mi-g.github.io/jocly/examples/browser/control.html?game=glinski-chess

(Not related to the Github issue.): The latter one can be easily tested manually, by using myself but not the former one which will have an adverse effect on the ratings systems. :smile:

(I am talking only to myself here, not to the other people!): The ratings systems does not matter at all, at least to me, if not the other people. Just enjoy playing the game simply!

mi-g commented 6 years ago

yes, on www.jocly.com, the pawn promotion still be absent.

It will be present on the github repository but it's not yet available on the demo page (i will rebuild it as soon as i find some time).

raman22feb1988 commented 6 years ago

Just to gain (and then improve) my own knowledge simply,

would you mind explaining to me about what is the procedure to update the www.jocly.com website pages from the Github repository? And then by using what application or software it can be done around?

Well, let me know very well about this type of thing around, just simply, at all. Thank you.

By the way, just curious, may I know about what is that demo page around, anyway, after all? Which you had mentioned about it around, above, not below.

mi-g commented 6 years ago

would you mind explaining to me about what is the procedure to update the www.jocly.com website pages from the Github repository?

the procedure is kind of harsh: the www.jocly.com application has to be entirely rewritten

By the way, just curious, may I know about what is that demo page around, anyway, after all? Which you had mentioned about it around, above, not below.

This is the Jocly core demo page. You can set it up in your own environment and you will have the promotion issue fixed.

raman22feb1988 commented 6 years ago

the procedure is kind of harsh: the www.jocly.com application has to be entirely rewritten

What I meant was that: What are the sequence of commands that are to be given to the computer to host the www.jocly.com website pages from (by using) the Github source code?

mi-g commented 6 years ago

The sequence of commands to have www.jocly.com to run over the github Jocly core ?

rm -r *
code .

That's it :)

More seriously, Jocly evolved from a small program that was originally written to run the Scrum game in 2D. Patch after patch, it became what is now www.jocly.com (and the associated mobile apps), with a number of wrong architecture choices (even if some of them were the right decisions at the time). So i rewrote a clean library with a nice and documented API to give access to the core functionalities of Jocly: the rules implementation, the game 2D/3D interface, the artificial intelligence. Having an application that runs over this API to provide the equivalent of the current www.jocly.com is yet to be done. I don't have the time to do so myself for now, but anyone with regular web development skills could do it.

raman22feb1988 commented 6 years ago

The sequence of commands to have www.jocly.com to run over the github Jocly core ?

rm -r *
code .

That's it :)

And also I would like to know: Where (in what system and in what directory) you will need to execute these two commands to launch the www.jocly.com website pages from (by using) the Github source code? Also, will doing rm -r * not remove the currently ongoing playing games, last played games and ratings stored for all the different registered users for all the different played games from the www.jocly.com website pages, but only updates the game rules, the user interface and the AI?

If you update the www.jocly.com website pages, then will the new additions like Wild Tamerlane, Gigachess, Terachess, 360 Chess Authoring, Losing Chess and Suicide Checkers which are currently not available on the www.jocly.com website pages, but only currently available on the demo pages, be added up from the www.jocly.com website pages? Also, if you update the www.jocly.com website pages, then will the games like Chomp, Chomp Kids, Chomp 10, Chopsticks, Chopsticks Leftovers, Chopsticks Exact Play, Musketeer Chess, Mu Torere, Awele, Dots and Boxes, Dots and Boxes for Kids, Oc and Boxes, Dots and Boxes Chakana and Tic Tac Toe which are not currently available on the demo page but only currently available on the www.jocly.com website pages, be not removed away from the www.jocly.com website pages?

And seriously is it not possible to upgrade the www.jocly.com website pages without entirely rewriting with the www.jocly.com application? Why or why not, is it so, being the case?

yes, on www.jocly.com, the pawn promotion still be absent.

It will be present on the github repository but it's not yet available on the demo page (i will rebuild it as soon as i find some time).

By the way, why is the pawn promotion for Brusky Chess, De Vasa Chess and even McCooey Chess and Glinski Chess (for the latter two chess variants, pawn promotion was missing only at two points?), bug fixed issue not still available on the demo page, as of yet?

By the way, this issue was created from (by using) Big John. When he was playing a game of Mana against me, he asked me where to report bugs. There were bugs of pawn promotion in some hexagonal chess board variants. I pointed out to him directly the link of this Github repository website page, as you just before itself mentioned away to me this place in the www.jocly.com website pages community forum - Google groups mailing list, simply, at all, after all.

mi-g commented 6 years ago

Also, if you update the www.jocly.com website pages, then will the games like Chomp, Chomp Kids, Chomp 10, Chopsticks, Chopsticks Leftovers, Chopsticks Exact Play, Musketeer Chess, Mu Torere, Awele, Dots and Boxes, Dots and Boxes for Kids, Oc and Boxes, Dots and Boxes Chakana and Tic Tac Toe which are not currently available on the demo page but only currently available on the www.jocly.com website pages, be not removed away from the www.jocly.com website pages?

Only the games that had a 3D user interface have been ported to the new Jocly lib.

And seriously is it not possible to upgrade the www.jocly.com website pages without entirely rewriting with the www.jocly.com application? Why or why not, is it so, being the case?

I believe i answered that question many times already.

raman22feb1988 commented 6 years ago

I believe I answered that question many times already.

Oops, you were trying to answer for an unimportant question of mine, still, as of yet. Please consider answering for the first three questions of mine whatever I had mentioned in the post above, or something like that type of thing.

  1. Where (in what system and in what directory) you will need to execute these two commands to launch the www.jocly.com website pages from (by using) the Github source code?
  2. Also, will doing rm -r * not remove the currently ongoing playing games, last played games and ratings stored for all the different registered users for all the different played games from the www.jocly.com website pages, but only updates the game rules, the user interface and the AI?
  3. If you update the www.jocly.com website pages, then will the new additions like Wild Tamerlane, Gigachess, Terachess, 360 Chess Authoring, Losing Chess and Suicide Checkers which are currently not available on the www.jocly.com website pages, but only currently available on the demo pages, be added up from the www.jocly.com website pages?

Only the games that had a 3D user interface have been ported to the new Jocly lib.

By new Jocly lib, do you mean the demo page? Do the remaining games whatever I had mentioned in the post above have not got with a 3D user interface at all, or something like that type of thing, still, as of yet?

It appears that you are intentionally making me to ask and repeat with the same question again and again till I get the response properly and to the correct question. May be that it is a language issue only. Who knows about all that, ever?

mi-g commented 6 years ago

This is my final response.

Where (in what system and in what directory) you will need to execute these two commands to launch the www.jocly.com website pages from (by using) the Github source code?

When i quoted the 2 commands, it was some kind of humour attempt, apparently misunderstood: i was trying to say, "to have www.jocly.com pages to use the github source code, you have to remove everything (rm -r *) and start over (code . to launch the editor)". I just forgot to mention it also takes a few million keystrokes to rewrite the app from scratch.

Also, will doing rm -r * not remove the currently ongoing playing games, last played games and ratings stored for all the different registered users for all the different played games from the www.jocly.com website pages, but only updates the game rules, the user interface and the AI?

Again, humour about the rm -r *... In the next www.jocly.com, i'll do my best to import as much history data, like ratings and played games, as possible from the old (current) www.jocly.com.

If you update the www.jocly.com website pages, then will the new additions like Wild Tamerlane, Gigachess, Terachess, 360 Chess Authoring, Losing Chess and Suicide Checkers which are currently not available on the www.jocly.com website pages, but only currently available on the demo pages, be added up from the www.jocly.com website pages?

When i will rewrite entirely www.jocly.com, it will of course contain all the games available from the Jocly core lib.

By new Jocly lib, do you mean the demo page? Do the remaining games whatever I had mentioned in the post above have not got with a 3D user interface at all, or something like that type of thing, still, as of yet?

By "Jocly lib", i mean the Jocly core library that is hosted on GitHub. The demo page is simply a sample application to demonstrate how to make an application using the library. This demo is playable though.