search

aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.72k stars 280 forks source link

Constant CPU usage for no reason. Code trustwothy? #146

Closed navid-zamani closed 1 year ago

navid-zamani commented 1 year ago

Since there strangely is no bug tracker for DownloadHelper itself, I’ll report this here:

The Video DownloadHelper add-on constantly uses way more CPU than it should, even when no downloads are active, and nothing is watched in the browser.

I don’t know how to start it, other than having downloaded a video previously in the same session (browser hasn’t been closed in-between), but I can reliably stop the CPU hogging, by disabling the Video DownloadHelper extension.

Browser: Firefox (has been the case for at least a year, probably several, so should be the case in any version) OS: Linux/systemd/Mint (ditto)

EDIT (to fix bad wording): I am not sure the app is really trustworthy.
So if nothing happens, we’re gonna have to look into if it does anything nefarious, and if it does, report it.

TM818 commented 1 year ago

Any word on this? Video Download Helper is a pretty widely installed app and has been for a long time - did you find or get any confirmation it actually does contain malware?

navid-zamani commented 1 year ago

Any word on this?

I have not been able to pin the CPU usage down, unfortunately. Mainly due to lack of interest. I suspect it may be two add-ons constantly triggering each other due to changes in the page. But I left the add-on disabled, since I have to do work. So it is gone now, and I only enable VDH for when I need it. Which is only for sites which yt-dlp does not support for what I can ony describe as schizoid reasons. ;)

But for the record: I did not think there was malware inside. I worded this badly at the moment. Don’t make that assumption. Logic is not binary but ternary: Yes | No | Dunno. … And I don’t want to be the news media. So now I changed it, to only imply me questioning it, like I intended :)

Ergo, this big only serves to catch others who might have the same problem, and might investigate one step further… unless I have a real need to solve this.

(P.S.: Jeez, typing on a phone is a nightmare, both with and without autocorrect! Sorry for the many edits!)

kelvinwl commented 1 year ago

It can be only a bad or even not present code optimization. I'm not having an urgent need to dive into it too, so I'm subscribed to this issue to get any update.

paulrouget commented 1 year ago

I am not sure the app is really trustworthy.

Don't worry about that, and feel free to checkout the code, nothing shady is going on :)

I managed to reproduce, and the issue is most likely a zombie process of ffmpeg.

I'll be looking into that in the coming day.

paulrouget commented 1 year ago

With the latest ffmpeg (v6) this doesn't seem to happen again. This should be fixed in the next upcoming release.