aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.72k stars 280 forks source link

[meta] new version requirements #155

Closed paulrouget closed 1 year ago

paulrouget commented 1 year ago
paulrouget commented 1 year ago

For the flatpack issue:

Workarounds:

This seems to be the way: https://github.com/aclap-dev/vdhcoapp/issues/137#issuecomment-1544985068

paulrouget commented 1 year ago

Note for later:

The warning:

> Warning Cannot resolve 'adapters[adapter]'
  /Users/paul/downloadhelper/coapp/dist2/main.js
  Dynamic require may fail at run time, because the requested file
  is unknown at compilation time and not included into executable.
  Use a string literal as an argument for 'require', or leave it
  as is and specify the resolved file name in 'scripts' option.

Comes from: https://github.com/jaredwray/keyv/blob/a5528c4c5c3aeef34c8570cfb4f102a834322672/packages/keyv/src/index.js#L22

Gonna assume that only Map is necessary and ignore this warning.

paulrouget commented 1 year ago
paulrouget commented 1 year ago
paulrouget commented 1 year ago

I think we good. The only issue I haven't figured out is flatpak for chrome based browser. See README.