search

aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.72k stars 280 forks source link

Homebrew Installer? #175

Open AlJohri opened 11 months ago

AlJohri commented 11 months ago

Would it be possible to add this program to homebrew package manager so it can be installed on macOS using the CLI?

paulrouget commented 11 months ago

That's a great idea! I might look at this in the future, but if anyone is interested to write the homebrew script before that, here are the things to consider:

Ideally, each release should come with a homebrew version bump.

That should be enough.

dronenb commented 7 months ago

@paulrouget thanks for the info! I would be happy to write this cask. Would you prefer it be in a tap or in the upstream homebrew-cask?

dronenb commented 7 months ago

Also, is there any reason why we should use the .dmg instead of the .pkg? The .pkg might be a little easier since I presume it already runs the install script on your behalf and could also likely be used to figure out what files to uninstall...

dronenb commented 7 months ago

I went ahead and wrote a cask for this in my personal tap. I am happy to contribute it upstream, but would like @paulrouget to take a peek... https://github.com/dronenb/homebrew-tap/blob/main/Casks/video-downloadhelper-companion.rb

Since you already use GitHub actions, you could use something similar to https://github.com/marketplace/actions/homebrew-bump-cask to bump the cask to the new version through your CI.

paulrouget commented 7 months ago

Also, is there any reason why we should use the .dmg instead of the .pkg?

Like you already figured out, the pkg also runs the install command. dmg doesn't.

I went ahead and wrote a cask for this in my personal tap

That looks excellent! thank you!

I'm a little overwhelmed with work these days, might take some time to get into it. Or if you feel like it, go ahead a submit a PR.

dronenb commented 5 months ago

When I went to see if I could get this upstreamed, I found out there is already a cask available:

brew install --cask netdownloadhelpercoapp

The name isn't obvious, but the "token" (the name of the cask) is determined by Homebrew so as to have a consistent naming scheme. I added some enhancements in this upstream PR so the cask should work on older versions of macOS as well. Can we get this added into the official documentation?